updating to macos-14 #1486
Merged
updating to macos-14 #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhchandw
requested review from
paulr34,
tecimovic and
brdandu
as code owners
paulr34
approved these changes
Nov 21, 2024
tecimovic
approved these changes
Nov 21, 2024
| @@ -272,7 +272,7 @@ jobs: | |||
| - name: Verify zap-cli exists in Windows arm64 .zip package | |||
| if: startsWith(matrix.os, 'macos') | |||
| run: | | |||
| output=$(./node_modules/7zip-bin/mac/x64/7za l ./dist/zap-win-arm64.zip) | |||
| output=$(7za l ./dist/zap-win-arm64.zip) | |||
There was a problem hiding this comment.
I thought that's what npx is for? Shouldn't you do npx 7za ? I am confused why are you changing this path.
It is true, that running ./node_modules like it was is wrong, but npx should do that for you.
There was a problem hiding this comment.
https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md
7zip comes pre-installed as a utility in the macos-14 environment. I could change it to use the node module though.
dhchandw
force-pushed
the
task/updateActionsMacos14
branch
2 times, most recently
from
f593771
to
894a10c
Compare
tecimovic
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also using 7zip pre-installed library instead of using node module